search

NMoore-STEM / ASC-LLC-Redesign

Ananda Science Consulting webpage redesign
https://anandascience.com/
0 stars 0 forks source link

NM Portfolio - Modal buttons in mobile resolution #572

Closed NMoore-STEM closed 1 year ago

NMoore-STEM commented 1 year ago

Modal buttons for full resolution are showing in mobile resolution. Add declaration: display:none;.

NMoore-STEM commented 1 year ago

After adding this, it did not change once the files on the server were updated. Upon closer examination, I found that a declaration for the class "port_button" which stated display: inherit; was overriding the display:none; found in the "more_info" class. This was corrected in #595

NMoore-STEM commented 1 year ago

After removing display:inherit;, the problem seems to persist. I will need to go into HTML and CSS and sort out classes. Steps to take will include:

  1. Identify all classes (global, mobile, full, special resolutions)
  2. separate out type styles from box/object styles (background-color, dimensions, display, etc.)
  3. display declarations will need to reside solely in button-specific classes (which will not be present on any classes used in "details" modal buttons).
NMoore-STEM commented 1 year ago

NOTE: the display shows as intended on web dev tools, so cannot go off of this solely as it is not an accurate representation of what the end-user will see.

NMoore-STEM commented 1 year ago

After clearing browser caches and restarting apps, the problem seems to be resolved. If any further issues arise concerning these elements, refer to linked pull requests.