search

NNPDF / apfelcomb

Generates FK tables for NNPDF fits.
https://docs.nnpdf.science/external-code/grids.html
1 stars 0 forks source link

Added fkmerge2 #85

Closed enocera closed 1 year ago

enocera commented 2 years ago

This PR addresses https://github.com/NNPDF/nnpdf/issues/1540 reinstates FKmerge2 as fkmerge2, which was inadvertently deleted here https://github.com/NNPDF/nnpdf/commit/bed162e4a3ebc2e343f6289fc677863c552a6dd8

This is the dirtiest (but most minimal) implementation possible. The executable is generated in the apfelcomb/src folder and the user has to include this location to the PATH environmental variable. Perhaps explicit mention to this should be included in the documentation. Better installation locations can be considered, however I'm not sure if this is worth doing, in view of the fact that apfelcomb is going to be replaced.

cc @J-M-Moore

J-M-Moore commented 2 years ago

Looks great to me, thanks for doing this Emanuele!

Zaharid commented 1 year ago

@enocera @J-M-Moore can this be merged?

enocera commented 1 year ago

FWIAC yes.