search

NNPDF / hawaiian_vrap

vrap with pineappl
0 stars 0 forks source link

Add automatic regression tests #1

Closed scarlehoff closed 2 years ago

scarlehoff commented 2 years ago

I tried: https://github.com/scarlehoff/Hawaiian_vrap/runs/6114039640?check_suite_focus=true#step:5:118 but apparently it doesn't work.

No idea what the problem is, the compiler seems to be looking in the right directories. I'm not even sure whose fault is it, vrap or lhapdf. I'll disable the workflow for now.

Edit: the solution was to install gcc from conda as well ¯_ (ツ)_/¯

cschwan commented 2 years ago

It's a linking order problem, caused by a wrongly written autotools script. Commit 3dcd2e8213edf4297cfe06c553776085fd643a18 should fix it - using a different compiler just hides the problem.

cschwan commented 2 years ago

See https://stackoverflow.com/q/45135/812178 for a good discussion of the problem. This is the problem in our case on this line:

https://github.com/scarlehoff/Hawaiian_vrap/runs/6114039640?check_suite_focus=true#step:5:91

which says:

g++  -g -O2 -L/usr/share/miniconda/envs/test/lib -lLHAPDF   -o Vtot Vtot.o libVrap.a

but it must be

g++  -g -O2 -L/usr/share/miniconda/envs/test/lib Vtot.o libVrap.a -lLHAPDF   -o Vtot
scarlehoff commented 2 years ago

ah! I see. Sorry, saw the other comment before this one.