Closed scarlehoff closed 2 years ago
Looks good to me!
One thing that we have to investigate is which parameters Vrap uses as input. Once we want to make it part of the NNPDF theory predictions toolchain we must make sure that the apropriate parameters are passed from the theory data base to Vrap; for the time being having them hardcoded in Vrap is OK though.
@scarlehoff I've amended the README a little. I have two questions:
do we really need to copy the documentation from Dixon's web page in the README?
I guess you're right, I'll move it to the src
folder.
do we want to add a citation policy (referring to the NNPDF code paper and to Dixon's and Petriello's original paper)?
I don't think so. At maximum Dixon's and Petriello's original paper but I don't think the NNPDF code paper is really related to this repository atm (the pineappl paper would be actually a better one I think?)
@scarlehoff Very good - thanks.
I've modified the readme with the disclaimer that Frank has asked us to put there. I've also added a few more notes for context and plausible deniability.
Please have a look at the readme (and make any modifications that you find appropriate of course).
Once the readme is finished, I'll move it to the NNPDF organization. Once we have the factor of 54 sorted we can go public.
Closes #8