NNPDF / mcpdf

2 stars 0 forks source link

Implement flavor masks #5

Closed alecandido closed 2 years ago

alecandido commented 2 years ago

The last point is a bit more subtle, because it is more convenient to have a PDF as input (uniform FkTable.convolute signature with DIS, and at the end a PDF fully determines the input) but you need to mask luminosity, so:

This last part we can discuss together @tgiani.

alecandido commented 2 years ago

@tgiani I turned your commit into a PR, such that we can discuss here, and try to solve separately the problem.

Notebooks are hard to review (have a look to the "Files changed" tab and you find why by yourself ;D). So it is fine to use them to experiment, but try to turn them as part of the library as soon as possible. The further benefit is that directly developing a library makes everything more maintainable: it is easier to reuse and refactor.