search

NNPDF / nnusf

An open source machine learning framework that provides predictions for all-energy neutrino structure functions.
https://nnpdf.github.io/nnusf/
GNU General Public License v3.0
0 stars 0 forks source link

Implement W cut #23

Closed Radonirinaunimi closed 2 years ago

Radonirinaunimi commented 2 years ago

Add possibility to impose $W$ cuts in the fitting and plotting scripts.

RoyStegeman commented 2 years ago

What still needs to be done here?

Radonirinaunimi commented 2 years ago

What still needs to be done here?

This is pretty much done. I have already a full fit (I will add the model to the server), I will just have to generate the plots after lunch and will circulate the results.

RoyStegeman commented 2 years ago

That was indeed the impression I had from looking at the code. I guess this can be marked "ready for review"?

github-actions[bot] commented 2 years ago

:robot: The reports from the fits are now ready :robot: !

They are available in nnpdf:/home/nnpdf/WEB/NNUSF/botfits with the name results-140ba84-2022-07-07T12-42-40

Radonirinaunimi commented 2 years ago

That was indeed the impression I had from looking at the code. I guess this can be marked "ready for review"?

Yes! Let me just add one comment in the plotting part for the cut.

RoyStegeman commented 2 years ago

Okay lets merge this and then #25, so that #25 doesn't interfere with any future changes.

Radonirinaunimi commented 2 years ago

The model is in NNPDF:WEB/NNUSF/models/xconstraint-wcut-465ea9a.tar.gz. One thing to note is that each chi2_history.json now weights ~4MB each so we might do something about this. I will just merge this for now.

RoyStegeman commented 2 years ago

Okay, I'll add a runcard option for the fequency