search

NNPDF / nnusf

An open source machine learning framework that provides predictions for all-energy neutrino structure functions.
https://nnpdf.github.io/nnusf/
GNU General Public License v3.0
0 stars 0 forks source link

Fix files formatting using pre-commit hooks #25

Closed Radonirinaunimi closed 2 years ago

Radonirinaunimi commented 2 years ago

Finally fixes/standardizes all the files formatting by running pre-commit run --all-files.

RoyStegeman commented 2 years ago

I don't mind this so much, but maybe skip Juans pdfs_lo folder

github-actions[bot] commented 2 years ago

:robot: The reports from the fits are now ready :robot: !

They are available in nnpdf:/home/nnpdf/WEB/NNUSF/botfits with the name results-e802e1e-2022-07-07T16-34-56

Radonirinaunimi commented 2 years ago

I don't mind this so much, but maybe skip Juans pdfs_lo folder

I don't mind this as well, so let's just include it with everything else. Especially since if we add a flag the hook to ignore this we'll have to remove it again once this folder is removed.

RoyStegeman commented 2 years ago

I don't think I was clear. I meant that I don't mind this PR changing everything at once as opposed to only when a file is touched, but lets leave not do it for Juans files since it can be annoying if people reformat your code.

We don't need to worry about adding or removing any hooks since pre-commit is only applied to files that we change which will not be juans plotting script since we have our own. Just to be clear, does this commit do anything other than run pre-commit --all-files?

Radonirinaunimi commented 2 years ago

I don't think I was clear. I meant that I don't mind this PR changing everything at once as opposed to only when a file is touched, but lets leave not do it for Juans files since it can be annoying if people reformat your code.

Ah, I see! I can revert back the changes done on these two files.

Just to be clear, does this commit do anything other than run pre-commit run --all-files?

Nope, it is just that command.

RoyStegeman commented 2 years ago

Ah, I see! I can revert back the changes done on these two files.

Thanks, I think that would be better. Then feel free to merge after.