search

NNPDF / nnusf

An open source machine learning framework that provides predictions for all-energy neutrino structure functions.
https://nnpdf.github.io/nnusf/
GNU General Public License v3.0
0 stars 0 forks source link

Use run card name to be the fit folder name #60

Closed RoyStegeman closed 2 years ago

RoyStegeman commented 2 years ago

Related to this https://github.com/NNPDF/nnusf/pull/59#discussion_r1000774287

RoyStegeman commented 2 years ago

Though to be honest I think I would still be in favor of using the runcard name as default fitname

Radonirinaunimi commented 2 years ago

Though to be honest I think I would still be in favor of using the runcard name as default fitname

Yes! I definitely agree that this would be the best option.

Radonirinaunimi commented 2 years ago

Though to be honest I think I would still be in favor of using the runcard name as default fitname

Yes! I definitely agree that this would be the best option.

Should we do this here?

RoyStegeman commented 2 years ago

Yes I would say so

Radonirinaunimi commented 2 years ago

Okey, I will do that asap whenever I have a couple of minutes.

Radonirinaunimi commented 2 years ago

This now does the job. The user still has the possibility to choose the path but the naming will be the exact same as the run card.

RoyStegeman commented 2 years ago

Thanks

Radonirinaunimi commented 2 years ago

I also added the git info to the copied run card since this will not be part of the naming any longer.

If you're fine with this, we can merge this now.

RoyStegeman commented 2 years ago

Yes that's a good idea