search

NNPDF / nnusf

An open source machine learning framework that provides predictions for all-energy neutrino structure functions.
https://nnpdf.github.io/nnusf/
GNU General Public License v3.0
0 stars 0 forks source link

Implement pdf+th error for yadism grids #65

Closed RoyStegeman closed 1 year ago

RoyStegeman commented 2 years ago

The cli option exists, but so far only calculates the pdf error

Radonirinaunimi commented 2 years ago

This is indeed definitely true. Actually, right now the matching of the NNUSF to the Yadism predictions at high-Q2 only account for the PDF uncertainties. This will be important when Alfonso adds uncertainties to his plots. This, I forgot to mention when we chatted this morning about the missing bit.

ATM, I am not fully certain on how to best account for this here: https://github.com/NNPDF/nnusf/blob/f573bebed9b5e815a36005b255257a673661f6de/src/nnusf/theory/predictions.py#L140-L146

Radonirinaunimi commented 2 years ago

I haven't read this paper yet but would this method be consistent with what we do in the fit where PDF and Theory errors are accounted for by combining their covariance matrix in quadrature?

RoyStegeman commented 2 years ago

Yes sorry it's probably a bit too cumbersome for now so I removed the comment. Should indeed be consistent with what we usually do except that it accounts for the full correlations.

Radonirinaunimi commented 2 years ago

I see. There should be an easy way to do this, something along the lines of computing the the up and down shifts of the theory variations wrt to the central value and somehow add these information to the replicas.

RoyStegeman commented 2 years ago

Yes that's the default scale variations solution right; In which the observable shift observed upon performing a factor 1/2 and 2 shift of the scales is assumed equal to 1sigma (taking the largest observed shift when varying multiple scales). Then we can indeed sum the variances as you say.

I'm still not a huge fan of scale variations, but unfortunately it's the best/all we really have. Might be good to confirm with Juan before we proceed.

Radonirinaunimi commented 2 years ago

Sorry for the late reply, we had a QCD-EFT group meeting earlier.

Yes that's the default scale variations solution right; In which the observable shift observed upon performing a factor 1/2 and 2 shift of the scales is assumed equal to 1sigma (taking the largest observed shift when varying multiple scales). Then we can indeed sum the variances as you say.

I'm still not a huge fan of scale variations, but unfortunately it's the best/all we really have. Might be good to confirm with Juan before we proceed.

Me neither! However that's the best we could do so far. Currently tough, we are already including theory errors with the 7-point scale variation in the fit as agreed with Juan in https://github.com/NNPDF/nnusf/pull/47.

The problem I was seeing before was: how to properly account for these theory errors when dumping the Yadism predictions into a LHAPDF grid such that we are consistent with what we do in the fit? But now I think I might have an idea that I'm testing right now.

Radonirinaunimi commented 2 years ago

Nvm, what I intended to do does not work. Back into the drawing board.

Radonirinaunimi commented 1 year ago

Closing this as per discussion in the Slack.