search

NNPDF / nnusf

An open source machine learning framework that provides predictions for all-energy neutrino structure functions.
https://nnpdf.github.io/nnusf/
GNU General Public License v3.0
0 stars 0 forks source link

Retry with LHAPDF container #81

Closed alecandido closed 1 year ago

alecandido commented 1 year ago

Restore https://github.com/NNPDF/workflows/pkgs/container/lhapdf usage for workflows

In particular, the reason for which it was failing was an outdated yadism -> eko -> lz4 dependency, for which the wheel was not working on py3.10. With the hope that a more recent of version of yadism won't break anything else, this might solve the issue.

alecandido commented 1 year ago

@Radonirinaunimi is there a reason why you want to limit runs to the main branch? Or was it a leftover (before this PR it was even master)

alecandido commented 1 year ago

@Radonirinaunimi now this is failing in the very same way of #46

https://github.com/NNPDF/nnusf/actions/runs/4176825730/jobs/7233621133#step:8:12

If you agree, I'd propose you to merge (it simplifies the maintenance of LHAPDF installation to the only Container generation - and no surprise if you use a working container, since it is already installed, so nothing will be built in the workflow).

Radonirinaunimi commented 1 year ago

@Radonirinaunimi now this is failing in the very same way of #46

https://github.com/NNPDF/nnusf/actions/runs/4176825730/jobs/7233621133#step:8:12

If you agree, I'd propose you to merge (it simplifies the maintenance of LHAPDF installation to the only Container generation - and no surprise if you use a working container, since it is already installed, so nothing will be built in the workflow).

Awesome, thanks! Yes, I agree let's merge this and clean it up in #46.

@Radonirinaunimi is there a reason why you want to limit runs to the main branch? Or was it a leftover (before this PR it was even master)

It was indeed a leftover from a long time ago and did not bother to update it as I mainly dispatched actions manually. But I will fix this in #46 after this is merged.