search

NNPDF / pineappl

PineAPPL is not an extension of APPLgrid
https://nnpdf.github.io/pineappl/
GNU General Public License v3.0
12 stars 3 forks source link

Add FK table converter #137

Closed cschwan closed 2 years ago

cschwan commented 2 years ago

This PR adds a new feature fktable to the CLI subcommand import and converts (NNPDF) FK tables. This will close https://github.com/N3PDF/pineappl/issues/70.

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (3df8b24) into master (5779596) will decrease coverage by 0.09%. The diff coverage is 44.44%.

:exclamation: Current head 3df8b24 differs from pull request most recent head 1f7ab02. Consider uploading reports for the commit 1f7ab02 to get more accurate results

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   89.26%   89.17%   -0.10%     
==========================================
  Files          44       44              
  Lines        6578     6585       +7     
==========================================
  Hits         5872     5872              
- Misses        706      713       +7
Flag Coverage Δ
python 79.56% <ø> (ø)
rust 89.30% <44.44%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pineappl_cli/src/import.rs 84.78% <44.44%> (-5.89%) :arrow_down:
pineappl_cli/src/plot.rs 93.19% <0.00%> (-0.31%) :arrow_down:
pineappl/src/grid.rs 87.51% <0.00%> (ø)
pineappl/src/pids.rs 97.38% <0.00%> (ø)
pineappl_cli/src/info.rs 89.13% <0.00%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5779596...1f7ab02. Read the comment docs.

cschwan commented 2 years ago

The only thing missing is now is a unit test.