search

NNPDF / pineappl

PineAPPL is not an extension of APPLgrid
https://nnpdf.github.io/pineappl/
GNU General Public License v3.0
12 stars 3 forks source link

Support APPLgrid conversion with combined bins #175

Closed cschwan closed 1 year ago

cschwan commented 1 year ago

The pineappl importer can't convert grids in which in which multiple bins are combined together.

cschwan commented 1 year ago

To support the conversion of combined bins we need to merge subgrids with possibly different x1 and x2 grids. This has been implemented for ImportOnlySubgridV2 in commit aa884bf73aa4c85516e977fc8514d676f13226e5.

cschwan commented 1 year ago

Commit 85f76b5f708859879e546e35a3ee40dfdfed8122 improves the situation, but not all ploughshare grids with combined bins convert successfully.

cschwan commented 1 year ago

The remaining problems are mostly likely not with the converter itself, but appear rather when merging the converted subgrids together or even when convoluting the subgrid results.

cschwan commented 1 year ago

This bug should be fixed in commit 8b3c5c94bf3cb8b5ab07de182d6ee4279251426a.

cschwan commented 1 year ago

In commit ac17d56b3e343ecbb86d81e393a104f772e919bd I added a script that automatically downloads grids from ploughshare and converts them. All the grids convert successfully (also the fastNLO tables), so I'm going to close this issue.