search

NNPDF / pineappl

PineAPPL is not an extension of APPLgrid
https://nnpdf.github.io/pineappl/
GNU General Public License v3.0
12 stars 3 forks source link

Try using `rust-cov` instead of `grcov` #187

Closed cschwan closed 1 year ago

cschwan commented 1 year ago

This should improve the precision of the code coverage.

codecov-commenter commented 1 year ago

Codecov Report

Base: 91.86% // Head: 68.73% // Decreases project coverage by -23.12% :warning:

Coverage data is based on head (ffa39ac) compared to base (d9b2122). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #187 +/- ## =========================================== - Coverage 91.86% 68.73% -23.13% =========================================== Files 49 71 +22 Lines 7360 12827 +5467 =========================================== + Hits 6761 8817 +2056 - Misses 599 4010 +3411 ``` | Flag | Coverage Δ | | |---|---|---| | python | `78.35% <ø> (ø)` | | | rust | `68.66% <ø> (-23.38%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NNPDF/pineappl/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF) | Coverage Δ | | |---|---|---| | [pineappl\_cli/src/import/fktable.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9pbXBvcnQvZmt0YWJsZS5ycw==) | `0.00% <0.00%> (-95.34%)` | :arrow_down: | | [pineappl\_cli/src/import/applgrid.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9pbXBvcnQvYXBwbGdyaWQucnM=) | `0.00% <0.00%> (-93.01%)` | :arrow_down: | | [pineappl\_cli/src/obl.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9vYmwucnM=) | `0.00% <0.00%> (-92.00%)` | :arrow_down: | | [pineappl\_cli/src/pull.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9wdWxsLnJz) | `4.56% <0.00%> (-90.89%)` | :arrow_down: | | [pineappl\_cli/src/set.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9zZXQucnM=) | `2.63% <0.00%> (-90.56%)` | :arrow_down: | | [pineappl\_cli/src/merge.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9tZXJnZS5ycw==) | `2.85% <0.00%> (-90.00%)` | :arrow_down: | | [pineappl\_cli/src/diff.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9kaWZmLnJz) | `6.40% <0.00%> (-89.65%)` | :arrow_down: | | [pineappl\_cli/src/plot.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9wbG90LnJz) | `1.44% <0.00%> (-89.56%)` | :arrow_down: | | [pineappl\_cli/src/import/fastnlo.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9pbXBvcnQvZmFzdG5sby5ycw==) | `0.00% <0.00%> (-89.32%)` | :arrow_down: | | [pineappl\_cli/src/channels.rs](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-cGluZWFwcGxfY2xpL3NyYy9jaGFubmVscy5ycw==) | `5.64% <0.00%> (-89.31%)` | :arrow_down: | | ... and [52 more](https://codecov.io/gh/NNPDF/pineappl/pull/187/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alecandido commented 1 year ago

Why did you remove APPL and fastNLO conversion from the workflow?

cschwan commented 1 year ago

Why did you remove APPL and fastNLO conversion from the workflow?

Only to speed up the CI - they aren't relevant for this branch. I will add them back before I merge this branch into master.