search

NNPDF / pineappl

PineAPPL is not an extension of APPLgrid
https://nnpdf.github.io/pineappl/
GNU General Public License v3.0
13 stars 3 forks source link

Raise versions of `pineappl_applgrid` and `pineappl_fastnlo` to match `pineappl`'s #189

Closed cschwan closed 1 year ago

cschwan commented 1 year ago

For some reason I decided to decouple the version numbers of pineappl_applgrid and pineappl_fastnlo from the pineappl, pineappl_capi, pineappl_cli and pineappl_py. This isn't a good idea because in this way we have to release them manually, meaning ./make_release.sh don't cover them. Before releasing the next version we should simply increase their version numbers.

alecandido commented 1 year ago

I suggest to change this line: https://github.com/NNPDF/pineappl/blob/ecb140aa1a432a1f2797e52eca921f6b58a13e98/make_release.sh#L83 and actually store them in a variable, just not to make them hidden in the middle of the script.

Also this part should make use of the variable and do a loop: https://github.com/NNPDF/pineappl/blob/ecb140aa1a432a1f2797e52eca921f6b58a13e98/make_release.sh#L91-L111 just split the first one, or maybe better branch if the name is exactly pineappl to wait 60s.

cschwan commented 1 year ago

@AleCandido good points, I also changed the feature checks in commit 58158e6d97f8e6a8a5b52d27743dd7b9b1924a06.

cschwan commented 1 year ago

In commits 2aad2a8c24954e0b1f59231c6b3b002cd7677dd2 and e02f8d794685af8ddafb0ddc1d54a72d0af18861 I added changes so that the versions of the two crates are automatically synchronized with all the other crates.