NNPDF / pineappl

PineAPPL is not an extension of APPLgrid
https://nnpdf.github.io/pineappl/
GNU General Public License v3.0
12 stars 3 forks source link

Problem with Python deployment #211

Closed cschwan closed 1 year ago

cschwan commented 1 year ago

The Python deployment currently doesn't work, because maturin is too old. We need at least 0.13.4, see also commit fc50e9c5d785076968f52ad9b913e32c0415bfa5. @AleCandido, could you take care of this? Podman doesn't work reliably on my system at work and I'm not sure I can upload it.

cschwan commented 1 year ago

@andreab1997 this is probably causing https://github.com/NNPDF/pineko/actions/runs/4292741468/jobs/7479555051 to fail.

alecandido commented 1 year ago

@andreab1997 this is probably causing NNPDF/pineko/actions/runs/4292741468/jobs/7479555051 to fail.

There I believe there might be two problems:

I will update the container (but this is a rather simple task, just have a look here https://github.com/NNPDF/pineappl/tree/master/pineappl_py/package)

If possible, I'd also like to get rid of that container at some point, but at the moment the quickest option is just to update it...

cschwan commented 1 year ago

If possible, I'd also like to get rid of that container at some point, but at the moment the quickest option is just to update it...

I was thinking of the same. We can use #208 for that, by basing the container on a manylinux image instead of the Rust image.

alecandido commented 1 year ago

We can use #208 for that, by basing the container on a manylinux image instead of the Rust image.

That is exactly the maturin container: it is just based on manylinux with Rust and Maturin installed.

Instead, I was thinking to revisit the maturin-action, most likely we can fully get rid of the whole container at all, and just delegate to it (it is also generate the workflow by itself).

cschwan commented 1 year ago

That would be even better!

andreab1997 commented 1 year ago

Ok then let me know what I should do for NNPDF/pineko/actions/runs/4292741468/jobs/7479555051

alecandido commented 1 year ago

@andreab1997 For what it concerns you, there has been no release yet. Unless you want to run tests on Windows.

cschwan commented 1 year ago

We now have a prerelease, however on MacOS only packages for Python 3.10 and 3.11 are available. We should double-check which are missing and add them.

alecandido commented 1 year ago

We now have a prerelease, however on MacOS only packages for Python 3.10 and 3.11 are available. We should double-check which are missing and add them.

It is a problem with the new workflow, since before we also had the MacOS wheels for 3.7, 3.8, and 3.9 https://pypi.org/project/pineappl/0.5.9/#files

cschwan commented 1 year ago

Let's address the Python version problems in this branch: https://github.com/NNPDF/pineappl/pull/214.

cschwan commented 1 year ago

I believe we fixed all problems we had, shall I try to make another prerelease to check the 'release' part of the Wheels CI, @AleCandido?

cschwan commented 1 year ago

I believe all problems have been fixed.

alecandido commented 1 year ago

Thanks @cschwan