Improve OO C++ interface

NNPDF / pineappl

PineAPPL is not an extension of APPLgrid

https://nnpdf.github.io/pineappl/

GNU General Public License v3.0

12 stars 3 forks source link

Improve OO C++ interface #251

Closed felixhekhorn closed 5 months ago

felixhekhorn commented 7 months ago

Improvements from actual usage:

expose scale and optimize

felixhekhorn commented 5 months ago

Is there any chance to have PineAPPL.hpp be delivered next to pineappl_capi.h by default?

cschwan commented 5 months ago

We should be able to install the static header using the configuration file changes described in cargo-c's README, using asset in [package.metadata.capi.install.include], but my first try was unsuccessful. Let me check why.

alecandido commented 5 months ago

Small advice: use lowercase names for files, to avoid potential issues with case sensitivity. (feel free to ignore)

felixhekhorn commented 5 months ago

Can you please make the periods consistent? Some sentences and with a period, some without. Otherwise this LGTM.

Done in e72a5d6

cschwan commented 5 months ago

Is there any chance to have PineAPPL.hpp be delivered next to pineappl_capi.h by default?

This is implemented in commit 422d6723ea3d1ee57f2db3f386ea40332f9c97fe. Note that PineAPPL.hpp is now in pineappl_capi/include.