NNPDF / pineappl

PineAPPL is not an extension of APPLgrid
https://nnpdf.github.io/pineappl/
GNU General Public License v3.0
12 stars 3 forks source link

Expose the luminosity and bin mask options for FKs to the python interface #273

Closed scarlehoff closed 2 months ago

scarlehoff commented 2 months ago

It seems to work. I've just copied it from the grid.

cschwan commented 2 months ago

This looks good to me. It would be perfect if you could also add a small test.

alecandido commented 2 months ago

I'm working on fixing the signature.

Of course, you could drop the last commit and merge, but I believe to be valuable to avoid some overhead (whenever possible).

scarlehoff commented 2 months ago

As you wish, since you are at it please add also the test that @cschwan asked for.

scarlehoff commented 2 months ago

Thanks @alecandido

As a note for the future, we should add maybe a test that does the entire grid -> eko-convolution -> fktable and checks that the fktable can be read. Just to get a heads up in case any part of the interface changes.