NNPDF / pineappl

PineAPPL is not an extension of APPLgrid

https://nnpdf.github.io/pineappl/

GNU General Public License v3.0

12 stars 3 forks source link

Release Python Workflow #72

Closed alecandido closed 3 years ago

alecandido commented 3 years ago

It might work as it is, but:

[x] if possible switch from ${{ secrets.PYPI_PWD }} (yet to be provided) to ${{ secrets.PYPI_TOKEN }} (already present)
[x] test on PyPI test
- even locally would be fine
- but this is not possible for macOS (of course...), then find a way to use maturin with PyPI test and temporarily replace event with workflow_dispatch
[x] decide a name: the name of the PyPI package will be the one of the crate specified in pineappl_py/Cargo.toml (thus pineappl it's not available, even though it will be the name of the python package used with import, since it is the one used in pineappl_py/src/lib.rs) https://github.com/N3PDF/pineappl/blob/65e3c137cd9aba1cc4c5a3c84312820328c58582/pineappl_py/Cargo.toml#L2 https://github.com/N3PDF/pineappl/blob/65e3c137cd9aba1cc4c5a3c84312820328c58582/pineappl_py/src/lib.rs#L12-L13

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (efeb77c) into master (3e10437) will not change coverage. The diff coverage is n/a.

:exclamation: Current head efeb77c differs from pull request most recent head 4660700. Consider uploading reports for the commit 4660700 to get more accurate results

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          18       18           
  Lines        1959     1959           
=======================================
  Hits         1296     1296           
  Misses        663      663

Impacted Files	Coverage Δ
pineappl/src/grid.rs	`41.83% <0.00%> (ø)`
pineappl/src/fk_table.rs	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e10437...4660700. Read the comment docs.

alecandido commented 3 years ago

The linux release has been tested manually using the container, but both workflows are not tested because it will only be possible after merging with master.

cschwan commented 3 years ago

Concerning the name I've found this: https://github.com/PyO3/maturin/issues/313#issuecomment-784438527 - can you try that?

alecandido commented 3 years ago

I will do as soon as possible

alecandido commented 3 years ago

Now it is actually working, producing wheels for the pineappl python package :D