NNPDF / pineappl

PineAPPL is not an extension of APPLgrid
https://nnpdf.github.io/pineappl/
GNU General Public License v3.0
12 stars 3 forks source link

Fix `Grid::convolute_subgrid` #97

Closed cschwan closed 1 year ago

cschwan commented 2 years ago

The method Grid::convolute_subgrid returns wrong results for many subgrid types because reweighting isn't considered, see also the following comment:

https://github.com/N3PDF/pineappl/blob/7b8b306c008ffded9efcd62cb43b0c9b06eb7f6d/pineappl/src/grid.rs#L636

This affects the following subgrid types for which it must be fixed:

This doesn't affect ImportOnlySubgridV1 and ImportOnlySubgridV2, however, so that while technically this is a bug, all optimized grids aren't affected by it.