search

NNPDF / pinecards

Runcards needed to generate PineAPPL grids for NNPDF processes
3 stars 1 forks source link

Read perturbative order from theory card for vrap #149

Closed scarlehoff closed 2 years ago

scarlehoff commented 2 years ago

NNLO is now implemented in vrap: https://github.com/NNPDF/hawaiian_vrap/pull/21

In order to enable in the pinefarm I've modified the runner for vrap so that the order computed is the order given by the runcard.

The positivity grids instead can only be computed at NLO at the moment because I cannot think of any tricks that wouldn't mean rewriting half of vrap :(

codecov-commenter commented 2 years ago

Codecov Report

Merging #149 (3075f80) into master (970a2bb) will decrease coverage by 0.24%. The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   29.53%   29.28%   -0.25%     
==========================================
  Files          23       23              
  Lines        1141     1154      +13     
==========================================
+ Hits          337      338       +1     
- Misses        804      816      +12
Flag Coverage Δ
unittests 29.28% <22.22%> (-0.25%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pinefarm/external/vrap.py 23.07% <22.22%> (-1.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 970a2bb...3075f80. Read the comment docs.

felixhekhorn commented 2 years ago

Is there something more needed for this?

scarlehoff commented 2 years ago

A 1.3 release in the vrap repository which I just did. This should be good to go.

Fktables have never been generated for this but I guess for the time being we don't need them in any of the theories we are fitting.