NNPDF / pinecards

Runcards needed to generate PineAPPL grids for NNPDF processes
3 stars 1 forks source link

Rename datasets consistently? #82

Closed cschwan closed 3 years ago

cschwan commented 3 years ago

The naming scheme of the datasets is inconsistent; some use underscores, some don't. We should also remove NORM from all names as the PineAPPL grids aren't normalised.

cschwan commented 3 years ago

@enocera What do you think about that? I've already seen that you've renamed a few datasets in this repository compared to the one in the APPLgrids repository. I suggest we rename according to the following scheme:

  1. experiment: ATLAS, CMS, LHCB, and NNPDFXX (for internal use)
  2. process/distribution description: 1JET, 2JET, DY, TTB, ZPT
  3. centre-of-mass energy: 5TEV, 7TEV, 8TEV, 13TEV
  4. variants:
    1. integrated luminosity: 49FB, 940PB, 2FB
    2. distribution dimensionality: TOT, 2D, 3D
    3. observable/variant description: R06, 2L, LJ
    4. bin limits for runcards that have been split up into several directories
cschwan commented 3 years ago

See https://github.com/NNPDF/runcards/pull/98 for an implementation of my suggestion. If you do an ls in the datasets directory, this looks much more clearly IMO:

ATLAS_1JET_8TEV_R06
ATLAS_2JET_7TEV_R06
ATLAS_DY_7TEV_49FB_HIMASS
ATLAS_DY_7TEV_CC
ATLAS_DY_7TEV_CF
ATLAS_DY_7TEV_LOMASS_EXT
ATLAS_DY_8TEV_2D
ATLAS_DY_8TEV_3D_046080_0007
ATLAS_DY_8TEV_3D_046080_0710
ATLAS_DY_8TEV_3D_080102_0007
ATLAS_DY_8TEV_3D_080102_0710
ATLAS_DY_8TEV_3D_102200_0007
ATLAS_DY_8TEV_3D_102200_0710
ATLAS_TTB_13TEV_TOT
ATLAS_TTB_7TEV_TOT
ATLAS_TTB_8TEV_2L_TTM
ATLAS_TTB_8TEV_2L_TTRAP
ATLAS_TTB_8TEV_LJ_TPT
ATLAS_TTB_8TEV_LJ_TRAP
ATLAS_TTB_8TEV_LJ_TTM
ATLAS_TTB_8TEV_LJ_TTRAP
ATLAS_TTB_8TEV_TOT
ATLAS_W_7TEV_WM
ATLAS_W_7TEV_WP
CMS_2JET_7TEV
CMS_2JET_8TEV_3D
CMS_DY_7TEV_2D
CMS_TTB_13TEV_2L_TPT
CMS_TTB_13TEV_2L_TRAP
CMS_TTB_13TEV_2L_TTM
CMS_TTB_13TEV_2L_TTRAP
CMS_TTB_13TEV_LJ_TPT
CMS_TTB_13TEV_LJ_TRAP
CMS_TTB_13TEV_LJ_TTM
CMS_TTB_13TEV_LJ_TTRAP
CMS_TTB_5TEV_TOT
CMS_TTB_8TEV_2D_TPT_TRAP
CMS_TTB_8TEV_2D_TTM_TRAP
CMS_TTB_8TEV_2D_TTM_TTRAP
CMS_ZPT_13TEV
LHCB_DY_13TEV_DIELECTRON
LHCB_DY_13TEV_DIMUON
LHCB_DY_7TEV
LHCB_DY_7TEV_940PB
LHCB_DY_8TEV
LHCB_DY_8TEV_2FB
LHCB_W_7TEV_WM
LHCB_W_7TEV_WP
LHCB_W_8TEV_WM
LHCB_W_8TEV_WP
enocera commented 3 years ago

@cschwan I think that the issue is delicate, because there's not necessarily a one-to-one correspondence between the APPLgrid/PineAPPL grid names and the names of the data sets. If your question is about the names of the PineAPPL grids, then I agree with you; we can delegate to apfelcomb how to combine grids into FK tables that match the names of the data sets.

cschwan commented 3 years ago

@enocera exactly, I just want to rename the PineAPPL grids, everything else I don't care about (yet).