NNPDF / pinefarm

Generate PineAPPL grids from PineCards
https://pinefarm.readthedocs.io
GNU General Public License v3.0
1 stars 0 forks source link

pinefarm requires pinecards to be in a repo #12

Closed felixhekhorn closed 1 year ago

felixhekhorn commented 1 year ago

@niclaurenti got hit by the following bug:

in https://github.com/NNPDF/runcards/blob/7f11afce4242791acad47d4c7be393e629b5121d/pinefarm/external/interface.py#L114 we require that we are inside an actual repo (as would be in development mode, so when cloning this repo) - not being so, as can happen e.g. upon pip install pineline[full] and adding some stand alone cards, results in an exception (@niclaurenti if you still have - please paste the full error here)

I guess we should catch that error and eventually leave the field empty

felixhekhorn commented 1 year ago

@niclaurenti actually the other problem you faced, i.e. that the grid was not lz4 compressed, is a direct consequence of this bug because you never reached this line here https://github.com/NNPDF/runcards/blob/7f11afce4242791acad47d4c7be393e629b5121d/pinefarm/external/interface.py#L154 which would do it

felixhekhorn commented 1 year ago

@niclaurenti if you wish you can even open a PR here and do what I proposed:

I guess we should catch that error and eventually leave the field empty

you already know which exception to catch ;-)

niclaurenti commented 1 year ago

@felixhekhorn the error is the following (running with the pinefarm installed from pip install 'pineline[full]'

Traceback (most recent call last):
File "/home/laurenti/n3pdf/pineline/env/bin/pinefarm", line 8, in <module>
sys.exit(command())
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
return self.main(*args, **kwargs)
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/pinefarm/cli/run.py", line 31, in subcommand
main(dataset, theory_card, pdf)
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/pinefarm/cli/run.py", line 67, in main
run_dataset(runner)
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/pinefarm/cli/run.py", line 132, in run_dataset
runner.annotate_versions()
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/pinefarm/external/interface.py", line 115, in annotate_versions
versions["pinecard"] = pygit2.Repository(
File "/home/laurenti/n3pdf/pineline/env/lib/python3.10/site-packages/pygit2/repository.py", line 1620, in __init__
path_backend = init_file_backend(path, flags)
_pygit2.GitError: Repository not found at /home/laurenti/n3pdf/pineline
alecandido commented 1 year ago

This will be solved by #15

felixhekhorn commented 1 year ago

Closed via https://github.com/NNPDF/pinefarm/pull/23