NNPDF / pinefarm

Generate PineAPPL grids from PineCards
https://pinefarm.readthedocs.io
GNU General Public License v3.0
1 stars 0 forks source link

Create theory_405.yaml #14

Closed felixhekhorn closed 1 year ago

felixhekhorn commented 1 year ago

port of https://github.com/NNPDF/runcards/pull/166

looks good to me by the way

alecandido commented 1 year ago

Yes, it should be fine. At some point, I want to write a small function that downloads the theory db (either the SQL from the repo or the HTML table) and cache it locally, such that we can load from there.

Maybe we will still need some extra parameters, but these can be treated separately.

andreab1997 commented 1 year ago

The theory card should be good. However when using it to compute the NLO DIS grids, it happens than the computed grids contain also the NNLO terms. Moreover, checking with pineappl diff, they are exactly the same as the theory 400 grids. Does this make sense to you? (cc @scarlehoff)

alecandido commented 1 year ago

it happens than the computed grids contain also the NNLO terms

This is fine, because it is FONLL-B

andreab1997 commented 1 year ago

The theory card should be good. However when using it to compute the NLO DIS grids, it happens than the computed grids contain also the NNLO terms. Moreover, checking with pineappl diff, they are exactly the same as the theory 400 grids. Does this make sense to you? (cc @scarlehoff)

Ok sorry, it seems that this was an error. So, everything should be fine as far as I understood.

codecov[bot] commented 1 year ago

Codecov Report

Base: 29.61% // Head: 29.61% // No change to project coverage :thumbsup:

Coverage data is based on head (149910f) compared to base (302568c). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14 +/- ## ======================================= Coverage 29.61% 29.61% ======================================= Files 24 24 Lines 1246 1246 ======================================= Hits 369 369 Misses 877 877 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `29.61% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

felixhekhorn commented 1 year ago

It is indeed outdated and does not correspond to theory 405 any longer (no b displacement) ... I now think, we should not store theory cards here. This should be done on a more global level instead ... see also https://github.com/NNPDF/nnpdf/issues/1705 (cc @scarlehoff )

just to stress the point that we should do something sooner or later: on Friday @Radonirinaunimi was asking me for an official theory card and all I could do was to reply: "please ask @andreab1997, he knows"