search

NNPDF / pinefarm

Generate PineAPPL grids from PineCards
https://pinefarm.readthedocs.io
GNU General Public License v3.0
1 stars 0 forks source link

Drop pinecard version #16

Closed felixhekhorn closed 1 year ago

felixhekhorn commented 1 year ago

related to https://github.com/NNPDF/runcards/pull/159

since the original behaviour resulted into a failure I suggest to drop the pinecard for the moment completely and then do the proper job in https://github.com/NNPDF/pinefarm/issues/15

alecandido commented 1 year ago

since the original behaviour resulted into a failure I suggest to drop the pinecard for the moment completely and then do the proper job in #15

I would do the other way round...

cschwan commented 1 year ago

How would you do it?

alecandido commented 1 year ago

Provide directly the alternative, before dropping the current behavior. I do not want to obtain something that produces grids that are not reproducible, since it will make easier to postpone and forget the issue.

cschwan commented 1 year ago

In other words: fix #15 first, then this issue. I agree with that.

codecov[bot] commented 1 year ago

Codecov Report

Base: 29.61% // Head: 29.63% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (d44b2b5) compared to base (302568c). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16 +/- ## ========================================== + Coverage 29.61% 29.63% +0.02% ========================================== Files 24 24 Lines 1246 1245 -1 ========================================== Hits 369 369 + Misses 877 876 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `29.63% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NNPDF/pinefarm/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF) | Coverage Δ | | |---|---|---| | [src/pinefarm/external/interface.py](https://codecov.io/gh/NNPDF/pinefarm/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#diff-c3JjL3BpbmVmYXJtL2V4dGVybmFsL2ludGVyZmFjZS5weQ==) | `41.53% <ø> (+0.62%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

felixhekhorn commented 1 year ago

Closed in favor of #23