search

NNPDF / pinefarm

Generate PineAPPL grids from PineCards
https://pinefarm.readthedocs.io
GNU General Public License v3.0
1 stars 0 forks source link

Fix polarized integrability #58

Closed giacomomagni closed 8 months ago

giacomomagni commented 8 months ago

~55c26ea843fbbae18ce5634d8b775b47bf02ef95 is not enough to compute f(x) and xf(x).~

~I need to adjust also here:~

https://github.com/NNPDF/pinefarm/blob/71f4b737bc8faeb0bdc650e5ae742922310d6a8f/src/pinefarm/external/integrability.py#L83-L87

This PR is to make integrability running again.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (897dde6) 29.12% compared to head (53c80db) 29.18%. Report is 1 commits behind head on main.

Files Patch % Lines
src/pinefarm/external/integrability.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## ========================================== + Coverage 29.12% 29.18% +0.05% ========================================== Files 24 24 Lines 1260 1261 +1 ========================================== + Hits 367 368 +1 Misses 893 893 ``` | [Flag](https://app.codecov.io/gh/NNPDF/pinefarm/pull/58/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NNPDF/pinefarm/pull/58/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF) | `29.18% <50.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NNPDF#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

giacomomagni commented 8 months ago

@felixhekhorn, the only change here w.r.t #57 is in the following line:

https://github.com/NNPDF/pinefarm/blob/53c80dbc1ea2cadeca4ebc73e41c52bd55f9139c/src/pinefarm/external/integrability.py#L63

yes this is mainly to ensure backward compatibility with the pinecards without polarization.