search

NNPDF / reportengine

A framework for declarative data analysis
https://data.nnpdf.science/validphys-docs/guide.html
GNU General Public License v2.0
1 stars 2 forks source link

Problem with lockfiles #30

Closed scarlehoff closed 4 years ago

scarlehoff commented 4 years ago

I'm getting the following error using the latest version of reportengine

Traceback (most recent call last):
  File "/media/storageSSD/Academic_Workspace/NNPDF/source/nnpdf/n3fit/src/n3fit/n3fit.py", line 193, in run
    super().run()
  File "/media/storageSSD/Academic_Workspace/NNPDF/source/nnpdf/validphys2/src/validphys/app.py", line 144, in run
    super().run()
  File "/media/storageSSD/Academic_Workspace/NNPDF/source/reportengine/src/reportengine/app.py", line 353, in run
    c.dump_lockfile()
  File "/media/storageSSD/Academic_Workspace/NNPDF/source/reportengine/src/reportengine/configparser.py", line 803, in dump_lockfile
    with open(self.environment.input_folder/"lockfile.yaml", "w+") as f:
AttributeError: 'N3FitEnvironment' object has no attribute 'input_folder'

For now I'm staying at 901aa52686e2f2b96e96d766af32aa5499c84793 which was working fine

Things that might or not be relevant:

(not sure whether I should've changed something in n3fit to accommodate the changes)

Zaharid commented 4 years ago

I think the best thing to do is to make sure all environment classes have input_folder. It's part of the interface anyway.

wilsonmr commented 4 years ago

yeah I guess I don't have much to add, I think I just assumed the input_folder would always be created... I guess vp-setupfit and postfit could also be affected by this change

wilsonmr commented 4 years ago

perhaps could check that input_folder exists before dumping the lockfile?

Zaharid commented 4 years ago

Nah, really let's just add it to the environments. We want lockfiles in n3fit anyway.

On Mon, 23 Mar 2020, 14:03 wilsonmr, notifications@github.com wrote:

perhaps could check that input_folder exists before dumping the lockfile?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NNPDF/reportengine/issues/30#issuecomment-602575834, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLJWUWOOEGXMHCVQCL2JELRI5M3HANCNFSM4LMC5NLQ .

Zaharid commented 4 years ago

This is now fixed in NNPDF.