Closed scarlehoff closed 4 years ago
I think the best thing to do is to make sure all environment classes have input_folder
. It's part of the interface anyway.
yeah I guess I don't have much to add, I think I just assumed the input_folder would always be created... I guess vp-setupfit and postfit could also be affected by this change
perhaps could check that input_folder exists before dumping the lockfile?
Nah, really let's just add it to the environments. We want lockfiles in n3fit anyway.
On Mon, 23 Mar 2020, 14:03 wilsonmr, notifications@github.com wrote:
perhaps could check that input_folder exists before dumping the lockfile?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NNPDF/reportengine/issues/30#issuecomment-602575834, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLJWUWOOEGXMHCVQCL2JELRI5M3HANCNFSM4LMC5NLQ .
This is now fixed in NNPDF.
I'm getting the following error using the latest version of
reportengine
For now I'm staying at 901aa52686e2f2b96e96d766af32aa5499c84793 which was working fine
Things that might or not be relevant:
(not sure whether I should've changed something in
n3fit
to accommodate the changes)