search

NNPDF / reportengine

A framework for declarative data analysis
https://data.nnpdf.science/validphys-docs/guide.html
GNU General Public License v2.0
1 stars 2 forks source link

Add pip command to readme and a list of requirements #36

Closed scarlehoff closed 3 years ago

scarlehoff commented 4 years ago

As the title suggest, this commit adds the possibility of installing reportengine with pip directly from github so that dependencies are automatically installed.

Zaharid commented 4 years ago

I don't think you can install pandoc with pip. Indeed the pip package is some (rather unfortunately named) wrapper library that requires the actual pandoc program:

https://github.com/boisgera/pandoc

scarlehoff commented 4 years ago

Oh, didn't notice. That's :sad: ... and evil.

I would still prefer having all the dependences -other than pandoc- install automatically though, but that's a major drawback...

Zaharid commented 3 years ago

I have moved the python dependency managed to flit and also have uploaded some version of the package to PyPI. That will have to be managed manually for now.

scarlehoff commented 3 years ago

Is it possible to install with flit from github like with pip? If so it would be nice to have that in the readme as well.

In any case the issue is mostly resolved as with the pip install you get the deps which is what I wanted.

ps: although I am not sure how I feel about having to install a dependency specifically to install packages...

Zaharid commented 3 years ago

Seems like 

pip install --upgrade git+https://github.com/NNPDF/reportengine.git

works fine.

You can install in develop mode with flit install --symlink. At some point in the future one should be able to do pip install -e . as before but not now. In general I am very apprehensive of dealing with any setuptools related complications. flit makes it slightly easier and the extra dev dependency (that users don't need to see) is worth it.