search

NNPDF / reportengine

A framework for declarative data analysis
https://data.nnpdf.science/validphys-docs/guide.html
GNU General Public License v2.0
1 stars 2 forks source link

Create a new tag or release for reportengine #59

Open scarlehoff opened 10 months ago

scarlehoff commented 10 months ago

reportengine has changed quite a lot since the last tag/release, in particular the dash stuff that @comane added clearly warrants a new release/tag https://github.com/NNPDF/nnpdf/pull/1804#issuecomment-1763985339

And an associated question which should have been formulated sooner... @Zaharid are you planning to keep on maintaining reportengine?

Zaharid commented 10 months ago

I would not count on that.

That said I can try to make sure the code is distributed in various places when the teats pass.

scarlehoff commented 10 months ago

@comane is the PR #57 fixing the test that is failing master?

comane commented 10 months ago

@scarlehoff I just closed PR https://github.com/NNPDF/reportengine/pull/57 since it was not needed anymore after merging #56

To what test are you referring to?

scarlehoff commented 10 months ago

https://github.com/NNPDF/reportengine/actions/runs/5762321933/job/15621863471