search

NO-ob / LoliSnatcher_Droid

A booru client with support for batch downloading
GNU Affero General Public License v3.0
372 stars 23 forks source link

add Linux build #122

Closed ghost closed 2 years ago

ghost commented 2 years ago

This adds linux/ directory with (mostly) files generated by flutter. I just changed the package name in CMakeLists.txt

drwankingstein commented 2 years ago

commit reorg p8 lowercase file names - c5371832fd5caef8871fca3b93c08c13de207864 broke this it does work on the previous commit however

unrelated problem

NO-ob commented 2 years ago

thanks, did you have any luck with video playback working, it has been broken on my system for a while

drwankingstein commented 2 years ago

did you have any luck with video playback working, it has been broken on my system for a while

that sometimes happens to me when modifying it. only solution I have found is to do a fresh re-clone and build, I can't say for sure but I think flutter tool isn't cleaning build files properly and they get corrupted

ghost commented 2 years ago

@NO-ob I tried video playback just now

the main issue seems to be that it seems to instantly throw a NaN error when I select a video in search list, but if I wait a few seconds it does get rid of the error and play back the video successfully i haven't looked at the code, but i think it's trying to render the video element (as an image? the stack trace comes from PhotoViewControllerValue) before having gotten enough information to figure out what to do with it

some other occasional errors, not sure what these are about:

[00007f254858e8c0] main decoder error: Timestamp conversion failed for 66734: no reference clock
[00007f254858e8c0] main decoder error: Could not convert timestamp 0 for FFmpeg
[00007f254800abb0] http stream error: local stream 5 error: Cancellation (0x8)
[00007f254800abb0] http stream error: local stream 5 error: Stream closed (0x5)

# this error seems to be because the video playback element tries to keep playing the video even once it's not on screen anymore
[h264 @ 0x7f254893fb00] get_buffer() failed
[h264 @ 0x7f254893fb00] thread_get_buffer() failed
[h264 @ 0x7f254893fb00] decode_slice_header error
[h264 @ 0x7f254893fb00] no frame!

# guessing this error is also from trying to play back videos before they're fully downloaded, since it goes away after a few seconds
NANI-SORE commented 2 years ago

PhotoView is for interactivity (zoom, pan...), the NaN error is probably related to a code which tries to get video dimensions for better zooming. I copied it from mobile player, but now that I think about it, it's not necessary here, will remove in next commit. The main problem with videos is that current video handler for desktop is just a placeholder while we wait for official video support from google, I don't want to go too deep into fixing it when it's possible that we'll just drop it completely