search

NO-ob / LoliSnatcher_Droid

A booru client with support for batch downloading
GNU Affero General Public License v3.0
371 stars 23 forks source link

Specific tag (or symbol) returns nothing #172

Closed GlazeNine closed 1 year ago

GlazeNine commented 1 year ago

Screenshot_20221208-034933 App version: 2.3.0 (178) / Play Tag is "panty_&_stocking_with_garterbelt" Affected boorus: gelbooru, rule34.xxx, xbooru, sankaku. Rule34hentai and rule34paheal show pics but the tag there is "panty_AND_stocking_with_garterbelt" so maybe the "&" symbol is the problem here.

dizzydoo commented 1 year ago

Symbol is definitely the problem. Tested gelbooru, danbooru and rule34.xxx via a browser with the same API requests that lolisnatcher sends and they returned nothing because they skipped encoding the & symbol in the tags. Changing it to the proper HTML encoding %26 fixes it, but doesn't work in lolisnatcher since it looks like the % gets changed only, sending %2526 instead

NO-ob commented 1 year ago

Yeah theres some weirdness with encoding special characters, theres a similar problem with +. I am unsure how this can be fixed currently.

s-b-repo commented 1 year ago

t seems that the issue with LolSnatcher is that it is incorrectly encoding the "&" symbol in the API requests for certain websites. This results in the requests returning no results. The correct encoding for "&" in URL parameters is "%26", but it appears that LolSnatcher is converting it to "%2526", which is causing the problem.

NANI-SORE commented 1 year ago

Fixed in 2.3.3