search

NO-ob / LoliSnatcher_Droid

A booru client with support for batch downloading
GNU Affero General Public License v3.0
371 stars 23 forks source link

Split into multiple packages with Melos #198

Open Vinrobot opened 1 year ago

Vinrobot commented 1 year ago

Hello, I'm would like to use some parts of you application (the boorus engines) in custom scripts. But currently, the boorus engines are in the application and I will separate it to use it in my projects.

I would like to know if you would be interested in seeing the modifications being merged in this repo?

What I would do is the following: 1) Setup Melos to manage the packages 2) Separate the Boorus engine in a different package 3) Enjoy

If you are interested or have questions or comments then we can discuss. Otherwise, you can just close this issue.

Have a nice day.

NANI-SORE commented 1 year ago

We recently discussed about making booru handlers work as separately installable plugins but in the end decided not to due to how complex that would be to implement. So I'm not sure how you would go about separating booru handlers from the app. They are very interconnected with multiple other systems in the app (database, network, settings, logging...). It will probably be easier for you to start from scratch and maybe only copy the parts related to parsing. Just don't forget to credit us if you do.

@NO-ob Your thoughts on this?

NO-ob commented 1 year ago

Yeah having a package for the booru stuff would probably be nice but I am not sure of a good way to separate the functionality especially when the db is also used for session dump/restore. Its probably better to just take the handlers out for your usage until we have good separation of functionality