search

NO-ob / LoliSnatcher_Droid

A booru client with support for batch downloading
GNU Affero General Public License v3.0
398 stars 26 forks source link

[Feature Request] Collection of Feature Suggestions, Tweaks, and Booru Addition Suggestions #4

Open seniorm0ment opened 4 years ago

seniorm0ment commented 4 years ago

Suggestions:

NO-ob commented 4 years ago

Thanks for the suggestions I will probably add most of these eventually

Ability to select size of thumbnails (see more on the screen when browsing)

Do you mean having the ability to choose how many columns there are instead of the default 2?

Color code tags

I like this feature and did try adding this to the desktop version at one point but I worry it will make the app slow because to implement it I think i'd have to make a database storing all of the tags and give each one a type so a colour could be assigned to them, but this would require querying the data base for each tag when results are retrieved from a booru and I think that would slow down searching a whole lot so i'm not sure about it. The way I tried before was using gelboorus api as it lets you search tags and will tell you what type they are so a colour can be assigned but this was extremely slow so maybe a database will be faster but I still worry it will slow down the app considerably when running a search

Offer (or change) the viewed image information (tag popup, and would include the provided info suggestion as above) menu as a hamburger menu that comes from the right, instead of a popup menu

I think i'd probably go with a popup as I dont particularly like hamburger menus lel but thought it was suitable for the app menu, so would you want an information button that shows a popup like with tags but instead of showing tags it shows all the other stuff that was above

Not directly related to the app, and I assume this will be done eventually, but I hope to see the desktop application updated to match the android app in feature set with time. Some ability to sync favorites with desktop client (monitored folder maybe, that can be synced over Syncthing/rsync)

Regarding the desktop client do you mean the one from the other LoliSnatcher repo or the desktop build from this repo? Also for syncing between them that something I will deffo try make available once I've added favourites

seniorm0ment commented 4 years ago

Ability to select size of thumbnails (see more on the screen when browsing) Do you mean having the ability to choose how many columns there are instead of the default 2?

Yes

Color code tags

I like this feature and did try adding this to the desktop version at one point but I worry it will make the app slow because to implement it I think i'd have to make a database storing all of the tags and give each one a type so a colour could be assigned to them, but this would require querying the data base for each tag when results are retrieved from a booru and I think that would slow down searching a whole lot so i'm not sure about it. The way I tried before was using gelboorus api as it lets you search tags and will tell you what type they are so a colour can be assigned but this was extremely slow so maybe a database will be faster but I still worry it will slow down the app considerably when running a search

Hm, not too sure. I can tell you Animeboxes does this, although their source is closed. Can try talking with the dev maybe. Maybe a good intermediate would be some kind of caching system, then grab from Gelbooru for stuff it is missing.

Offer (or change) the viewed image information (tag popup, and would include the provided info suggestion as above) menu as a hamburger menu that comes from the right, instead of a popup menu I think i'd probably go with a popup as I dont particularly like hamburger menus lel but thought it was suitable for the app menu, so would you want an information button that shows a popup like with tags but instead of showing tags it shows all the other stuff that was above Personally I prefer hamburger menus lol, to each their own though. Not sure how big of a pita an option to switch the popup menus to right side hamburger menu would be. Either way, yes basically I'm suggesting it show info about the image at the top of the popup/hammenu and then right below it are the tags. Again, I like how Animeboxes does this, I think it's worth you just taking a look at it to see what I'm suggesting.

Not directly related to the app, and I assume this will be done eventually, but I hope to see the desktop application updated to match the android app in feature set with time. Some ability to sync favorites with desktop client (monitored folder maybe, that can be synced over Syncthing/rsync)

Regarding the desktop client do you mean the one from the other LoliSnatcher repo or the desktop build from this repo? Also for syncing between them that something I will deffo try make available once I've added favourites Oh, honestly didn't even notice there was a desktop build in this repo. I was talking about the LoliSnatcher repo. I assume the one here is meant to replace that, and this one is kept up to date?

NO-ob commented 4 years ago

Okay ill take a look at anime boxes at some point to see how it shows all this info.

There was a desktop version posted a couple of builds back but video viewing is currently broken https://github.com/NO-ob/LoliSnatcher_Droid/releases/tag/1.1 i'm not sure when this will be fixed as flutter on desktop is in very early stages but i will probably make it open videos in mpv instead like with the java version

I'm not sure if I want to update the java version further or eventually release desktop builds of this, the java version needs quite a lot of stuff rewritten to be able to add tab functionality and if im working on that i'd want to be able to submit it for my uni project so wont work on it until I get my assignment

NO-ob commented 4 years ago

I've added support for api key/userid will be a new build some time today or tomorrow. Will probably add booru specific default tags also

seniorm0ment commented 4 years ago

Glad to hear!

seniorm0ment commented 4 years ago

Just checked out the latest version, looks great. Tag pop up is very readable.

I do notice it seems to be a bit slow fetching images, especially when scrolling through. Also the animations when sliding between images isn't seamless, there's a blank screen between. Only other thing is videos not working and lack of autocomplete suggestions when searching.

Besides that it's running nice, I assume you're working on completing the page loading when in full view for the next version?

Maybe worth setting up a request to get it on F-Droid seeing that tends to take a week or two to get reviewed and added, then when you fix the page loading just push an update to F-Droid? (Lol I'm kinda desperate to get off Animeboxes, then I can just export my Animeboxes favorites and uninstall and wait until you look into fixing the import, but can view at least. Would like to see this on F-Droid though seeing I can't thoroughly review the code myself.)

Feels ready imo, looks good feels good. Love it, keep up the great work! I'm not a programmer but if you would like any input on anything feel free to ask I'll try my best.

NO-ob commented 4 years ago

I do notice it seems to be a bit slow fetching images, especially when scrolling through Is this on specific booru or all of them because I mostly use gelbooru but have noticed speed being worse on some booru's I think its a server side thing on their end tho

Only other thing is videos not working could you link some booru pages of videos that dont work I will look into that

autocomplete suggestions when searching. I'm not sure if i'm ever going to do this if i do it it will be quite a bit far in the future

Regarding the blank screen between pages that will be fixed either in the next version or version after, I need to make changes for android 11 first as r/w from the filesystem is broken on 11. Then I'm going to try to add the preloading which should fix the blank page issue I think its blank because the image doesn't start loading until the next page is on screen. After that ill probably try to make the image page full screen only showing buttons when tapped on.

With F-Droid I did look at getting it on there and i'm not sure if its possible to setup a flutter buildscript I will either contact them about this or setup my own repo to host the builds. I have submitted the app for the playstore and am currently waiting for it to be reviewed so it may be up on there in a week or so.

Thanks for the feedback

seniorm0ment commented 4 years ago

Good to hear, and yeah I'd try contacting them first and if not, your own repo would probably be the next best thing. Thank you.

NO-ob commented 4 years ago

Good to hear, and yeah I'd try contacting them first and if not, your own repo would probably be the next best thing. Thank you.

Tag suggestion and preloading have been added

seniorm0ment commented 4 years ago

Amazing!

seniorm0ment commented 4 years ago

Ok, I striked out the stuff you did, I think I got it all. Thanks!

NO-ob commented 4 years ago

Thanks, I have done the size of thumbnails and duplicate booru warning also

seniorm0ment commented 4 years ago

Fixed

seniorm0ment commented 3 years ago

Is there a reason for the limit on the amount it fetches? It's extremely restrictive

NANI-SORE commented 3 years ago

Hold down on an image/vid to hide the UI (immersive view), hold again to reshow

I added this and double tap to skip on videos in my PR #22 Should be available in the next update

seniorm0ment commented 3 years ago

just cleaned up op, removed whatever was done and any unneeded bloat.
didn't add anything new to the list, just removed and edited a few.