search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Tentative changes from final version used for photoacclimation experiments #12

Closed andrew-c-ross closed 3 months ago

andrew-c-ross commented 4 months ago

This PR would make COBALT equivalent to the version found in Charlie's generic_COBALT_08222023_control.F90. Some of the changes in this PR are specific to the needs of the global photoacclimation runs, however, and shouldn't be merged. Reviews would be appreciated to identify what should or shouldn't be merged.

yichengt900 commented 3 months ago

Thanks @andrew-c-ross! @charliestock, based on @nikizadehgfdl's comments during the COBALTv3 Focused Doc and Dev meeting, it seems that we can overwrite parameters using field_table without recompiling the code. This raises the following question: do we still want to update the default values to match those used in the manuscript, purely for the sake of consistency and reference?

yichengt900 commented 3 months ago

@charliestock, following our discussion, I think we will eventually go down the route of providing users with our recommended BGC parameters through a separate file, rather than editing the default values in the code. If so, I will close this PR for now and keep it as a reference. @andrew-c-ross are you ok with that?

andrew-c-ross commented 3 months ago

I think that sounds ok. Yeah I will keep my branch around, so with that branch and this closed PR we can always compare values if needed.