search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Missing Pointers for Benthic Fluxes in Direct Sinking of Phytoplankton P #18

Closed yichengt900 closed 3 months ago

yichengt900 commented 3 months ago

In the recent code review, we discovered that the pointers for the benthic fluxes for the direct sinking of phytoplankton P were not correctly set in the generic_COBALT_update_from_bottom subroutine. This may be one reason why our P budget analysis cannot be closed. Additionally, this discovery motivates us to reconsider our current imbalance check approach, as it may not detect issues occurring outside the COBALT modules.

This issue is being raised on behalf of @charliestock.

charliestock commented 3 months ago

Thank you for handling this Yi-Cheng, The net effect of this was a small amount of unintended phosphate burial. This issue only impacts COBALTv3.0 and does not effect past versions of COBALT (for which phytoplankton sinking was not specified). Furthermore, the unintended P burial was fortunately very small and did not create areas of P limitation.