search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

added felim to diazo iron limitation #31

Closed charliestock closed 3 months ago

charliestock commented 3 months ago

This change updated the diazotroph iron limitation to be consistent with a change in the iron limitation calculation made for the other phytoplankton types in COBALTv3.0. The level of iron limitation is now calculated as the maximum of the limitations imposed by the internal cell quota (def_fe) and the ambient iron uptake limitation (felim).

While this fix changes answers, the effect is very small. It mainly removes small regions near river mouth where iron ends up being the most limiting nutrient simply because it takes a short time for high internal iron quotas to be established in high iron environments. Using the maximum of def_fe and felim removes this delay and puts iron on equal footing with N and P.

This adjustment also only effects the diazotrophs, which are generally a small fraction of the phytoplankton community.

yichengt900 commented 3 months ago

Thanks, @charliestock. It looks good to me. As you pointed out, the effect of this change is probably small and was not even caught by our 1D test case (which makes sense because our 1D test case is located in the middle of the ocean). I will approve it for now and will merge this PR once it has passed the NWA12 RT test.

yichengt900 commented 3 months ago

Ok it also passed the NWA12 RT test at the CEFI-regional-mom6 side. Will merge this PR now.