search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Cleanup: float index and unused variables #32

Closed andrew-c-ross closed 2 months ago

andrew-c-ross commented 3 months ago

I started this PR to fix the extremely minor issue of using a float as an index (mentioned in #29). While I was at it, though, I also cleaned up some other extremely minor issues reported by compiling with -Wall (some unused variables and all instances of tabs). None of these should have any effect on the actual model. There's a chance the unused variables indicate something that is unintentionally not included in the current source, though.

yichengt900 commented 3 months ago

Thanks, @andrew-c-ross. Although some of the changes, like tab removal, might be overwritten by #23, they all look good to me. I will keep this PR open for a while to give others a chance to review it

andrew-c-ross commented 3 months ago

Sounds good :+1: It's all extremely picky details that won't change anything, so there's no urgency

charliestock commented 2 months ago

Thanks for catching these Andrew, Yi-Cheng. It is good to catch these whether they are small or not!