search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Remove ERGOM, TOPAZ, and miniBLING modules #44

Closed yichengt900 closed 2 months ago

yichengt900 commented 2 months ago

As @nikizadehgfdl suggested in #21, the pull request (PR) removes the ERGOM, TOPAZ, and miniBLING modules, as well as associated variables and calls, from generic_tracer.F90.

charliestock commented 2 months ago

Following discussion with Yi-Cheng, this should be OK as long as we have other module options as a template (e.g., BLING, CFCs), and then lets rename the .F90, .F90.archive for TOPAZ, minibling and ERGOM, and then add a README. This should prevent compiling, and we can remove more completely if these modules continue to be unused.

yichengt900 commented 2 months ago

So instead of removing these modules directly, we rename them as generic_*.F90.archive, and we commented out all the related calls in generic_tracer.F90 for now.

yichengt900 commented 2 months ago

Hi @andrew-c-ross, I have addressed most of your comments except for the one regarding generic_tracer_vertdiff_M (which I will handle in a separate PR). Feel free to let me know if you have any further thoughts.