search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Change COBALT bottom fluxes from 3d array to 2d #46

Closed yichengt900 closed 2 months ago

yichengt900 commented 2 months ago

This PR resolves issue #38 by converting the COBALT bottom fluxes array from 3D to 2D, enhancing memory efficiency. this PR is solely for code refactoring and does not alter the modeled results.

yichengt900 commented 2 months ago

@andrew-c-ross, thank you. Regarding the side effects, perhaps we could consider renaming those diagnostics? For example, renaming cadet_arag_btf tob_cadet_arag to avoid confusion. What are your thoughts?

andrew-c-ross commented 2 months ago

Regarding the side effects, perhaps we could consider renaming those diagnostics? For example, renaming cadet_arag_btf tob_cadet_arag to avoid confusion.

I think it's fine to leave everything as is. The *_btf_btf diagnostic only appears if you look for it in the available_diags file.

andrew-c-ross commented 2 months ago

I looked at one of my older runs, for other variables that have a bottom flux, I don't see that bottom flux saved in the restarts (for example, I don't see no3_btf in the restarts). This could confirm Charlie's suspicion that the new diagnostic _btfs aren't being saved in the restarts.