search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Refactor github actions CI workflow #51

Closed yichengt900 closed 2 months ago

yichengt900 commented 2 months ago

Refactor GHA CI workflow to include 1D restart test as well as some other improvements. Now if the answers differ from the baselines, the workflow will halt and display the new answers, allowing users to copy new answers and update them in their PRs.

How to update your reference:

So if you find that your PR did not pass the COBALT CI check (with a red cross next to your PR title), you can first click the Details button:

Screenshot from 2024-04-18 15-20-39

It should take you to the page that shows you which step your PR did not pass. Below is an example where the PR changes the baseline answers and did not pass the baseline check: Screenshot from 2024-04-18 15-21-26

In this case, the person who opened the PR should copy the new answers shown on the screen and update the reference (located under ocean_BGC/.github/ref/OM4.single_column.COBALT.p4/docker-linux-gnu/ocean.stats).

yichengt900 commented 2 months ago

Hi @feida6996, thank you for inquiring about updating the baseline answers. I took this opportunity to refactor the testing workflow. Now, you should be able to copy and paste the new answers by following the instructions I provided in this PR or in the wiki page. I assigned you as a reviewer, just to inform you about this update. You do not have to perform a detailed review since this is an infrastructure development, but any suggestions you have are more than welcome. Also CC @NOAA-CEFI-Regional-Ocean-Modeling/gfdl-med.