search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

cleanup phytoplankton uptake section #58

Closed charliestock closed 1 month ago

charliestock commented 1 month ago

This pull request just cleans up the uptake code and adds a few comments. I have also suggested removing the diagnostic "net_phyto_resp", which we don't really use for anything and can be easily calculated from the growth rate. We should check to ensure this is not in our standard diagnostic tables.

These changes should not change answers.

yichengt900 commented 1 month ago

@charliestock , by checking our current NWA12 diag_table, we do output water column integrated net_phyto_resp.

charliestock commented 1 month ago

I think net_phyto_resp and wc_net_phyto_resp have now been successfully removed from the code. I have also confirmed that it is indeed redundant with other diagnostics. The only thing that we'll need to ensure is that the diagnostic "wc_net_phyto_resp" is removed from all of our diagnostic tables.