search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Added units and descriptions to O2 sat and Schmidt number calculations #65

Closed charliestock closed 4 weeks ago

charliestock commented 1 month ago

This pull request adds descriptions and units to the first thirty or so parameters using the formatting from Theresa's new parameter input interface. These are mainly the parameters to determine the O2 saturation and CO2 and O2 Schmidt numbers for air-sea exchange calculations.

In the latter case, I uncovered a few more details on the origin of these parameter choices and have put these in the comments. In particular, the W92 setting is actually a modified version of W92 that was provided to John Dunne by Wanninkhof to ensure the relationship was robust from -2 to 40 degrees. These were provided in an e-mail that John forwarded to me.

I was also able to remove one parameter, "NKML", that seemed to be unused.

I tested the simulations in the 1D water column and it ran successfully after adding the following lines to the namelist:

&cobalt_input_nml parameter_filename = 'COBALT_input', 'COBALT_override' /

and adding blank COBALT_input and COBALT_override files to the directory. We probably want to add these as standard entries/files for future runs. Thanks to @theresa-morrison for her guidance in addressing this.

charliestock commented 4 weeks ago

Added the Benson and Krause fit reference to the comment and sent a note to JPD and JGJ. Let's forge ahead with merging!

yichengt900 commented 4 weeks ago

Thanks, @charliestock and @andrew-c-ross . Looks like now everyone is happy with this PR. I will merge it now.

andrew-c-ross commented 4 weeks ago

@charliestock I did some more searching and confirmed that the Benson and Krause fit is what should have been used for OCMIP-2: https://web.archive.org/web/20051017101155fw_/http://www.ipsl.jussieu.fr/OCMIP/phase2/simulations/Biotic/boundcond/o2sato.f

charliestock commented 4 weeks ago

Thanks Andrew. I see they didn't offer any information on why they chose Benson and Krause. John knows Orr well, so I pinged him to see if he could get any insight before deciding on whether a change is warranted.