search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 8 forks source link

cleaned up plankton foodweb code #67

Closed charliestock closed 5 months ago

charliestock commented 5 months ago

This pull request cleans up the code associated with zooplankton and higher predator grazing. This involved:

1) Removing legacy code from COBALTv2 that had just been commented out 2) Removing code associated with an experimental diapause approximation that was not being used. 3) Removing an experimental "self grazing" setting that was not being used. 4) Improved commenting throughout.

The removal of the experimental diapause formulation means that the diagnostic tracer "irr_mem_dp" is no longer needed. Several diagnostics were also removed in the clean up, but none of these seems to appear in the diagnostic table.

I have tested the code and it runs. This should not change answers relative to the last version, and it ultimately removed about 100 lines of code.

charliestock commented 5 months ago

Great, thanks @yichengt900 and @jessluo - why don't we blend this in today and the next pull requests can build from this.

best, Charlie