search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Removed unused zooplankton upward swimming #68

Closed charliestock closed 3 weeks ago

charliestock commented 3 weeks ago

This pull request removes some preliminary work to implement upward zooplankton swimming to avoid detrainment. This was ultimately not used in any production codes and will be replaced with a more complete representation of zooplankton movement that Jessica is working on with Mathieu Poupon and Laure Resplandy.

This should not change answers. No changes to the diagnostic table are required, but we should probably delete the following lines (which were already commented out):

"generic_cobalt_z","chl2sfcchl", "chl2sfcchl", "ocean_cobalt_tracers_month_z","all","mean","none",2 "generic_cobalt_z","jupswim_n_Smz", "jupswim_n_Smz","ocean_cobalt_tracers_month_z","all","mean","none",2 "generic_cobalt_z","jupswim_n_Mdz", "jupswim_n_Mdz","ocean_cobalt_tracers_month_z","all","mean","none",2 "generic_cobalt_z","jupswim_n_Lgz", "jupswim_n_Lgz","ocean_cobalt_tracers_month_z","all","mean","none",2 "generic_cobalt_z","vmove_Smz", "vmove_Smz", "ocean_cobalt_tracers_month_z","all","mean","none",2 "generic_cobalt_z","vmove_Mdz", "vmove_Mdz", "ocean_cobalt_tracers_month_z","all","mean","none",2 "generic_cobalt_z","vmove_Lgz", "vmove_Lgz", "ocean_cobalt_tracers_month_z","all","mean","none",2

yichengt900 commented 3 weeks ago

@charliestock , Code changes look good, and it passed both 1D and NWA12-RT tests. Approve.