search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

added comments to the phytoplankton mortality section #69

Closed charliestock closed 2 weeks ago

charliestock commented 3 weeks ago

This pull request improves the commenting in the phytoplankton loss section. There were no changes to the actual code and it should not change answers. I have tagged @jessluo and @gabyneg for a quick look to ensure the commenting is accessible and informative.

charliestock commented 2 weeks ago

Hello @yichengt900 @gabyneg @jessluo - I added a commit that addressed the comment typo that Gaby caught and added comments to the rest of the plankton foodweb section. Take a quick look when/if you have a chance and perhaps we can pull this in on Monday?

thanks, Charlie

yichengt900 commented 2 weeks ago

Thanks @jessluo and @gabyneg! @charliestock, I fixed all the typos except for two great questions from @jessluo. I will merge this PR once they are resolved

jessluo commented 2 weeks ago

Thanks @jessluo and @gabyneg! @charliestock, I fixed all the typos except for two great questions from @jessluo. I will merge this PR once they are resolved

The second question is more of a science question, so I think only addressing the question on line 3622 would be fine for this PR.

charliestock commented 2 weeks ago

Thanks for the questions and comment typo fixes (and sorry there were so many). Agree that the second question is a good science one that can be addressed through sensitivities and subsequent pull requests. @yichengt900, if you could switch the other to nitrogen, that would be great.

yichengt900 commented 2 weeks ago

Thanks again @charliestock, @jessluo and @gabyneg for all your contributions to this PR. @charliestock I addressed all of the comments and this PR is ready to merge.