NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Consolidate generic tracer interface for cobalt-4p #7

Closed yichengt900 closed 5 months ago

yichengt900 commented 5 months ago

Currently there are a few modifications are required in MOM6 generic tracer interface in order to use cobalt-4p version. They are mainly:

  1. geolonT and geolatTfor calculation of day-length (e.g. https://github.com/NOAA-CEFI-Regional-Ocean-Modeling/ocean_BGC/blob/ec631ef65375de78c35a1891e67502b49b230507/patch/MOM6/src/tracer/MOM_generic_tracer.F90#L180)

  2. tv%eqn_of_state for density calculation to calculate the mld for the photoacclimation (e.g. https://github.com/NOAA-CEFI-Regional-Ocean-Modeling/ocean_BGC/blob/3db75ef0f3939a85e129e98802097e45666ca337/generic_tracers/generic_COBALT.F90#L7856)

We want to revisit these changes and make sure they are what we want before opening a pull request to the MOM6 main branch.