search

NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Remove vertdiff_M routines and make vertdiff_G just vertdiff #78

Closed andrew-c-ross closed 1 day ago

andrew-c-ross commented 2 days ago

This resolves #48 by removing everything related to vertdiff_M and renaming vertdiff_G to just vertdiff.

For this PR to work, MOM6 and ocean_BGC need to make the switch at at the same time (MOM6 PR: NOAA-CEFI-Regional-Ocean-Modeling/MOM6#11).

yichengt900 commented 2 days ago

@andrew-c-ross , Thanks! I reviewed the code changes and it lks good to me. I left my small concern here and perhaps we can discuss this during tomorrow's COBALTv3 dev meeting.

yichengt900 commented 2 days ago

@nikizadehgfdl, I am adding you to keep you in the loop. My understanding is that once we decide to push this change back to the GFDL main repo, it should not impact the existing experiment runs since we normally use specific tags for the experiments in xml. However, any additional thoughts you might have would be greatly appreciated.

andrew-c-ross commented 1 day ago

(We decided to revert the renaming of the vertdiff_G routines so that MOM6 doesn't need to be changed, with a longer-term vision of unifying the MOM6 and generic tracer vertdiff routines)