NOAA-CEFI-Regional-Ocean-Modeling / ocean_BGC

3 stars 4 forks source link

Simplify changes to the generic tracer interface for cobalt-p4: ocean_BGC side #8

Closed yichengt900 closed 5 months ago

yichengt900 commented 5 months ago

This PR is to address #7 .

The new cobalt-p4 requires several variables from MOM6 (e.g. geolat for day-length calculation as well as eqs_of_state for density calculation).

We revisited the initial modifications and removed unnecessary changes to minimize the impact on the generic tracer interface at the ocean_BGC side. The results match those obtained from the original codes in the 1-D and NWA12 RT tests.

I will conduct a 5-year run to ensure the consistency of the results. Update The restart files from this PR (/gpfs/f5/gfdl_med/scratch/Yi-cheng.Teng/fre/g_tracer/NWA12/NWA12_COBALT_2023_10_v2/ncrc5.intel22-prod/archive/restart) are identical to the baselines (/gpfs/f5/cefi/scratch/Yi-cheng.Teng/fre/cefi/NWA12/NWA12_COBALT_2023_10_v2/ncrc5.intel22-prod/archive).

Dependency: https://github.com/NOAA-CEFI-Regional-Ocean-Modeling/MOM6/pull/3