search

NOAA-CSL / MELODIES-MONET

MELODIES MONET - diagnostic tool for evaluating models against a variety of observations including surface, aircraft, and satellite data all within a common framework
https://melodies-monet.readthedocs.io
Apache License 2.0
19 stars 21 forks source link

Update reading in paired data for satellite evaluation #177

Open rschwant opened 1 year ago

rschwant commented 1 year ago

Satellite group mentioned that your method of reading in the paired data does not perfectly work for their needs (https://melodies-monet.readthedocs.io/en/latest/examples/read_paired_data.html) since you have to read in the yaml file, read in the obs, and model output and effectively you just skip the pairing step.

They want to be able to use the paired data for analysis and plotting without having to re-read in the model and observation data. Options to do this:

Store the meta data in the analysis class?

Or have an option to read in the observations and model output, but just to grab the meta data and not save the full output?

Or others?

Maggie (@mebruckner ) said she wrote in a way to bypass the reading in the observational data for now. Need to identify best way to update this for the future.

We would need to keep both options though. Because for contour overlay plots you would still need to read in the model output again fully and the paired output to make this plot.

mebruckner commented 1 year ago

To re-load the attributes for the model and observation classes I added the following to the read_analysis method: https://github.com/mebruckner/MELODIES-MONET-1/blob/61d0ee616b8c2d3d59e916c43daa09f30f4a3f2d/melodies_monet/driver.py#L643-L646 load_files is an optional argument I added to open_models and open_obs that defaults to True. Within the methods, I then added an if load_files statement around open_model_files and open_obs