search

NOAA-EDAB / Rpath

R implementation of the mass balance model Ecopath with Ecosim
http://NOAA-EDAB.github.io/Rpath
Other
29 stars 12 forks source link

Update vignettes #67

Open slucey opened 1 year ago

slucey commented 1 year ago

This adds the Anchovy Bay and REcosystem data sets only.

slucey commented 1 year ago

I'm looking into the failing gitleaks action that is failing everytime.

kaydin commented 1 year ago

@slucey do you want the raw R code files for these examples available for the user to inspect? Or just the compiled rdata files?

slucey commented 1 year ago

I think just the compiled rdata files. Although I think it is fine to have the scripts that created them in the data-raw folder.

slucey commented 1 year ago

@kaydin I'm talking with @rklasky about unit testing and I think we definitely want the script that creates these data sets available so we can build them as part of the unit test.

kaydin commented 6 months ago

@rklasky I've updated all of my packages and I'm still only seeing 34 tests but no warnings/errors. Here's what is output.

==> Rcpp::compileAttributes()

==> Sourcing R files in 'tests' directory

[1] "here::here: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath" [1] "OUTPUT_DATA_DIR: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath/tests/testthat/data/output" [1] "INPUT_DATA_DIR_BASELINE: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath/tests/testthat/data/input" [1] "INPUT_DATA_DIR_CURRENT: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath/tests/testthat/data/input" [1] "------------------ Rpath Object Tests ------------------" [1] "------------------ Forced Biomass Tests (Jitter) ------------------" [1] "------------------ Forced Biomass Tests (Stepped) ------------------" [1] "------------------ Forced Effort Tests (Jitter) ------------------" [1] "------------------ Forced Effort Tests (Stepped) ------------------" [1] "Completed 34 test(s)." [ FAIL 0 | WARN 0 | SKIP 0 | PASS 33 ]

Tests complete

rklasky commented 6 months ago

I just ran the tests locally on my machine and I had 54 tests. How did you generate the Unit Tests? Via a push or pull request?

-Ron

On Sun, May 5, 2024 at 2:52 PM kaydin @.***> wrote:

@rklasky https://github.com/rklasky I've updated all of my packages and I'm still only seeing 34 tests but no warnings/errors. Here's what is output.

==> Rcpp::compileAttributes()

  • Updated R/RcppExports.R

==> Sourcing R files in 'tests' directory

[1] "here::here: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath" [1] "OUTPUT_DATA_DIR: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath/tests/testthat/data/output" [1] "INPUT_DATA_DIR_BASELINE: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath/tests/testthat/data/input" [1] "INPUT_DATA_DIR_CURRENT: C:/Users/kerim.aydin/Work/src/sean_rpath/main_2023/Rpath/tests/testthat/data/input" [1] "------------------ Rpath Object Tests ------------------" [1] "------------------ Forced Biomass Tests (Jitter) ------------------" [1] "------------------ Forced Biomass Tests (Stepped) ------------------" [1] "------------------ Forced Effort Tests (Jitter) ------------------" [1] "------------------ Forced Effort Tests (Stepped) ------------------" [1] "Completed 34 test(s)." [ FAIL 0 | WARN 0 | SKIP 0 | PASS 33 ]

Tests complete

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EDAB/Rpath/pull/67#issuecomment-2094911394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZ6RSDC5G4TUN5UGSMOW63ZAZ5X5AVCNFSM6AAAAAA5JXQNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHEYTCMZZGQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Ron Klasky Contractor (remote) T and T Consulting Services, Inc. In Support of Office of Science and Technology | Ecosystem Management NOAA | National Marine Fisheries Service (321) 765-4465 (o) (661) 857-4720 (c)

kaydin commented 6 months ago

I just ran the tests locally on my machine and I had 54 tests. How did you generate the Unit Tests? Via a push or pull request?

Ran locally using the Rstudio test button (confirmed that my local dev is synced with origin/dev)

rklasky commented 6 months ago

Looking at it now. I think there may be a discrepancy with what's in dev and what's in my Unit Tests repo. I'm testing a push to Unit Tests but am not getting all 54 tests to pass. However, they all pass on my local machine when I click Test. Andy Beet's out until next week or else I'd run it by him. I'll keep banging on it and see if I can find what the issue is.

On Wed, May 8, 2024 at 6:33 PM kaydin @.***> wrote:

I just ran the tests locally on my machine and I had 54 tests. How did you generate the Unit Tests? Via a push or pull request?

Ran locally using the Rstudio test button (confirmed that my local dev is synced with origin/dev)

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EDAB/Rpath/pull/67#issuecomment-2101609328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZ6RSHS5TAPRZ5LMX6YW63ZBKR5HAVCNFSM6AAAAAA5JXQNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGYYDSMZSHA . You are receiving this because you were mentioned.Message ID: @.***>

-- Ron Klasky Contractor (remote) T and T Consulting Services, Inc. In Support of Office of Science and Technology | Ecosystem Management NOAA | National Marine Fisheries Service (321) 765-4465 (o) (661) 857-4720 (c)