Closed BBeltz1 closed 2 hours ago
Thanks Sarah, I'll take a look
This is happening because of the addition of the argument n
in some of the functions. The make_rmd
function has if
statements based on the number of function arguments. Will need to rework this function. May be a good idea to sketch out the flow of the function and think about a little rewrite
@BBeltz1 @sgaichas So i modified the make_rmd
function. This fix adds n=10
to the plots that were designated to have short term trend estimated. It's a little hacky but was quick. @BBeltz1 is reviewing it now. If this works we'll pull it into this Branch for all to review
@andybeet this is building correctly on my end now. thanks for the reminder about arfit
The requested changes have been made and are ready for review.
@sgaichas This builds for me. I see the figures for the two pages you referenced above. I also see the short term trend applied to some of the datasets. I think we might be good to go!
Much of the renaming of datasets occurred in our online issues. Those are complete but won't appear here.
Page names have been changed in the
bookdown.yml
file to ensure renamed pages propagate online. Page links will change according to new dataset names. Links to associated tech doc pages are also changed. These will not work until tech doc is pushed online as well.Issue template dropdowns have been adjusted with name replacements as well.
Catalog has been fully rebuilt to incorporate these name changes. Most pages shown below have not actually been changed.
This pull request needs 1 reviewer to verify that the book builds locally.
Closes #134